Lorenz Walthert

Results 536 comments of Lorenz Walthert
trafficstars

Yes, I am open to reviewing a PR from you. Other advantage is that in pre-commit, we’ll be able to extend the styler-hook as well.

Maybe we should talk about the abstract rule first. What is it exactly that we try to achieve? As for the code, I just wanted to say that you can...

as it is evident from the test cases, enforcing one argument per line is quite a change to the current behaviour I'd discourage this, at least at this point. Also,...

@IndrajeetPatil ok, let's leave it open. I might implement the above outlined solution at some point, God knows when 🤔

Thanks @jennybc, appreciated.

I am still trying to work out the differences between the two, but I don't think using both in the same repo makes sense. I suggested to Lionel and Davis...

I agree. @karangattu maybe change the title of the issue so people notice that they need to agree for this to proceed (like _licensing book down as MIT requires all...

Do I understand correctly from the related style guide PRs that in no situation, double indent is allowed?

If we don't have double indention anymore anywhere, can't we just (broadly speaking) revert https://github.com/r-lib/styler/pull/1083? I.e. the indent rules on braces that result from `function(\n...)` should already result the correct...

Yeah, I just meant that as far as indention goes (line breaks for single indent are an orthogonal topic I think), single indenting could be achieved by removing rules for...