Lorenz Walthert

Results 536 comments of Lorenz Walthert
trafficstars

@smingerson this is an important issue. Any progress on a sharable reprex? Maybe even one that can run on GitHub Actions?

Implemented as a local hook in {styler}: https://github.com/r-lib/styler/pull/765/files

Thanks. We could do that. But I think it's inherently a {testthat} problem, because it's quite generally accepted that there should be an empty line at EOF. Similar for `.Rd`...

I can't seem to find the problem with {roxygen2} anymore. There is https://github.com/r-lib/roxygen2/issues/593, but neither {styler} nor {precommit} has any file in `man/` where the trailing line break is missing....

Also note there were some discussions around this recently, maybe see if the problem persists with the dev version of {testthat}? https://github.com/r-lib/testthat/issues/1509

Also, I think using `exclude: '(\.Rd|^tests/testthat/_snaps/.*\.md)$` is also pretty non-ambiguous (if I got the regex right). Is it always `.md`?

> It seems that the precommit CI is styling the full package and not only the changed files. Is this indented? It does not seem that pre-commit.ci supports running on...

`.jpeg` are excluded in [recent templates](https://github.com/lorenzwalthert/precommit/tree/main/inst).

other consideration is to move the roxygenize hook back to `language: script` -.-

> I guess you already evaluated whether an explicit definition in the YAML is really required or if the deps could be installed silently in the background? Yes, explicit listing...