Lorenz Walthert

Results 536 comments of Lorenz Walthert
trafficstars

Other reference: https://github.com/kevinushey/rex/issues/75#issuecomment-994108532. In total, this reduces by 5 packages, in addition to earlier {lintr} dependency graph cut, which brought deps down from 70 to 58. https://github.com/lorenzwalthert/precommit/pull/315

Thanks @TNonet. Indeed, this repo layout does not work with the hook {precommit} provides. Pre-commit uses command line arguments to specify hook behaviour. Hence that's the natural solution I think....

> Does this seem reasonable? Because the file names are passed to the hook as relative paths, you may need to convert them to absolute paths (with base R preferably)...

@TNonet you can see #432 for how we could adapt hooks and tests. Do you want to continue in that fashion? I think we should only add the `--root` argument...

Ok, it was related to an error message that now has an absolute path. Fixed and re-based on main for a cleaner diff... All passing.

oh no, sorry to hear that. Hope everything is ok now… All CI passes, so I don’t know what’s the problem is on your side. Maybe update all your R...

Thanks @gravesti for raising this. I think indeed it could be useful. However, I'd not try to emulate what {pkgdown} does as a check, as this is less reliable than...

Pandoc dependency sounds like trouble, in particular in pre-commit.ci settings. Did you find the internal functions in {pkgdown} that are responsible to trigger ` * Topics missing from index: my_new_function`....

Do you need assistance in proceeding? I think your approach makes sense. We can also monky patch *our* dummy `render_page()` into `build_*_index()`, e.g. with {mockr} or {mockery}.

You can already do this by overriding `files` and `additional_dependencies: - r-lib/styler` in your `.pre-commit-config.yaml` if you want.