Lorenz Walthert

Results 536 comments of Lorenz Walthert
trafficstars

Ok, now I understand better, thanks. Since this is going to slow down styler, there must be a way to turn it off globally. I.e. one should be able to...

I am not currently working on that. We first need to outline conceptually what the implementation (or a first version) will look like. I think what I outlined in https://github.com/r-lib/styler/issues/247#issuecomment-485481338...

But I admit, the growing number of 👍 in the issue is motivating 😄

I know this is high up on the wish list for many users but I anticipate this to be quite complex and time consuming to implement. Given other priorities in...

Is there a corresponding rule in the tidyverse style or do you plan to add one?

Ok. I think this is easy to implement. I just think for the sake of consistency, we should in general aim to keep the style guide in sync with styler.

For a propper implementation, we'd need #357 because we want to add a line break dependent on whether a token is multi-line, which we cannot do if the multi-line attribute...

Implemented in mlr branch: https://github.com/lorenzwalthert/styler/commit/2a3fbc6fe278fbf9a09d229a49379d778536b5ed

The implementation in the mlr branch now depends on the number of lines in the body.