Kevin Rushforth

> In Joeri I trust :) Me, too. :)

> So I can reproduce this on my system now and could potentially test this PR. How would one go about this, testing a specific PR? You will need to...

Since this involved changing the specified behavior it will need a CSR. If we agree that this is the right behavior, then the CSR will be trivial. /csr /reviewers 2

This seems like a reasonable fix and spec change. Have you tested the case of calling sizeToScene before setting full-screen or maximzed? Since the pending flag will still be set...

Btw, I get the following test failures on our headful Linux test systems: ``` SizeToSceneFullscreenTest > testInitialSizeFullscreen FAILED java.lang.AssertionError: Stage height expected: but was: at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotEquals(Assert.java:835) at org.junit.Assert.assertEquals(Assert.java:555)...

@Maran23 I think this is pretty close to being ready to go in. At a minimum, you will need to merge master and then fix the test so that it...

I won't have time to do a detailed review for a while, but the updated approach to the fix looks promising. I note that the change in behavior will need...

@Maran23 Can you create the CSR? The updated docs (with the small suggestion I made) look ready.

@lukostyra Please re-review.

Based on those failures it would be a good idea to add tolerance to the check for >= visual bounds.