Kevin Rushforth

Results 489 comments of Kevin Rushforth
trafficstars

Reviewers: @johanvos @andy-goryachev-oracle @arapte @prrace I'd like at least 3 "R"eviewers to review this. Committers and Authors are also welcome to provide feedback. /reviewers 3 reviewers

I addressed most of the feedback. There are still one or two more items I might update for this PR, but I'll capture the rest in follow-up issues.

I filed the following follow-on bug to address and pending items: [JDK-8332642](https://bugs.openjdk.org/browse/JDK-8332642): Additional improvements to contribution and code review guidelines I think I have addressed all of the feedback so...

@johanvos Do you want to review this?

If there are bugs on macOS, then I'd file a separate bug, since this bug is only about Linux behavior. > Also on mac, as I understand it, there is...

> Is it ok to integrate? I got the e-mail saying so, but not really sure. Yes. There are two approving reviews, and no outstanding comments or questions.

Reviewers: @nlisker This will need discussion among and review by the Eclipse users on the list. /reviewers 2