8329821: [Linux] When using i3 WM, menus are incorrectly sized

[tsayao]

trafficstars

Simple fix to only request _NET_FRAME_EXTENTS if window has decoration.

It seems i3 replies with decorated sizes, even if window is not decorated.

Won't hurt other WMs.

---

Progress

• [ ] Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• [x] Change must not contain extraneous whitespace
• [x] Commit message must refer to an issue

Issue

• JDK-8329821: [Linux] When using i3 WM, menus are incorrectly sized (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1437/head:pull/1437
$ git checkout pull/1437

Update a local copy of the PR:
$ git checkout pull/1437
$ git pull https://git.openjdk.org/jfx.git pull/1437/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1437

View PR using the GUI difftool:
$ git pr show -t 1437

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1437.diff

Webrev

Link to Webrev Comment

[bridgekeeper[bot]]

:wave: Welcome back tsayao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk[bot]]

@tsayao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329821: [Linux] When using i3 WM, menus are incorrectly sized

Reviewed-by: arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

• 88aad93d07b36c8b32afd701c9180753db975e10: 8279140: ComboBox can lose selected value on item change via setAll
• 97b1402501983f121f75c24a510f466837fa2ecc: 8331748: Update libxml2 to 2.12.6
• 581e3a70a45a550a97e391e06735f4837336ada8: 8329011: Update SQLite to 3.45.3
• b86e6771b906bdf7ed517eb2d5ab76a2e92c1282: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming
• eb6d55f7f067469e89402da2bfa46e1ecf11ea02: 8328603: HLS video stream fails to render consistently
• 7699c448bbdfe4213f74eb47409d9c42b16b59a4: 8092102: Labeled: textTruncated property
• d3da033a2dd5c287733545935242a8d1f71c0554: 8330462: StringIndexOutOfBoundException when typing anything into TextField
• 35880cec5a998598c64eecbc7b3ae56b6ee3a6d8: 8331616: ChangeListener is not triggered when the InvalidationListener is removed
• 36e65e8b5ef12c6c3eef406d035a985a50000e0a: 8331214: Doc: update spec for SpinnerFactory classes
• 54005125a3f45489d3071eafd7f219ae621ff7c7: 8271865: SortedList::getViewIndex behaves not correctly for some index values
• ... and 39 more: https://git.openjdk.org/jfx/compare/eca323547ec0e84b40bebb213350b6cea5385904...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge[bot]]

Webrevs

• 00: Full (af283f9a)

[crschnick]

I recently got a report from a user running the latest xfce version that had the same problem where context menus and tooltips were cut off. But this fix is specific to i3?

[tsayao]

High chance it's the same problem.

[crschnick]

So I can reproduce this on my system now and could potentially test this PR. How would one go about this, testing a specific PR?

[kevinrushforth]

So I can reproduce this on my system now and could potentially test this PR. How would one go about this, testing a specific PR?

You will need to checkout the PR branch and build JavaFX from source. See the "Using git" instructions added by Skara in the "Reviewing" section of this PR's Description for how to fetch and checkout this PR branch. See the build instructions Wiki page for instructions on building JavaFX.

[crschnick]

I can confirm on my system that this PR fixes the issues that I am seeing and some users reported. Here is a before and after comparison for context menus and tooltips:

The tests also pass for me (didn't build webkit though)

[arapte]

I could verify that this change fixes the issue with i3 window manager. Shall do little more testing and update.

[tsayao]

/integrate

[openjdk[bot]]

Going to push as commit a7627fa8d4c0c2595d359a2656daf2f6005ee0f5. Since your change was applied there have been 49 commits pushed to the master branch:

• 88aad93d07b36c8b32afd701c9180753db975e10: 8279140: ComboBox can lose selected value on item change via setAll
• 97b1402501983f121f75c24a510f466837fa2ecc: 8331748: Update libxml2 to 2.12.6
• 581e3a70a45a550a97e391e06735f4837336ada8: 8329011: Update SQLite to 3.45.3
• b86e6771b906bdf7ed517eb2d5ab76a2e92c1282: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming
• eb6d55f7f067469e89402da2bfa46e1ecf11ea02: 8328603: HLS video stream fails to render consistently
• 7699c448bbdfe4213f74eb47409d9c42b16b59a4: 8092102: Labeled: textTruncated property
• d3da033a2dd5c287733545935242a8d1f71c0554: 8330462: StringIndexOutOfBoundException when typing anything into TextField
• 35880cec5a998598c64eecbc7b3ae56b6ee3a6d8: 8331616: ChangeListener is not triggered when the InvalidationListener is removed
• 36e65e8b5ef12c6c3eef406d035a985a50000e0a: 8331214: Doc: update spec for SpinnerFactory classes
• 54005125a3f45489d3071eafd7f219ae621ff7c7: 8271865: SortedList::getViewIndex behaves not correctly for some index values
• ... and 39 more: https://git.openjdk.org/jfx/compare/eca323547ec0e84b40bebb213350b6cea5385904...master

Your commit was automatically rebased without conflicts.

[openjdk[bot]]

@tsayao Pushed as commit a7627fa8d4c0c2595d359a2656daf2f6005ee0f5.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.