Kevin Rushforth

Getting back to this.... I ran the test on macOS and it now works as expected. However, one of the new tests fails on Linux: ``` SystemMenuBarTest > testFocusMemoryLeak FAILED...

> The failure on Linux has an interesting cause. The GlassSystemMenu (in com.sun.javafx.tk.quantum) has this code: > > ``` > /* > * Leave the Apple menu in place >...

Answering my own questions... The existing for loop quoted above actually loops while `>= 1` rather than `>= 0`: ``` for (int index = existingSize - 1; index >= 1;...

> > Further, I confirm that if I pass that option to jlink or jpackage when creating a custom runtime, there is no warning. > > Great! What about jpackage...

Not a review, but just a general comment or two. > EmojiTest has been converted to use the new test window as a demonstration That seems reasonable, but... > (also...

This could use a second pair of eyes. I don't have time right now, but I'll add a couple comments. /reviewers 2

We need to provide a build script for any manual test that isn't self-contained in a single directory (see my earlier comment). For example, we have a build script for...

@pisek As with your previously submitted PR #1318 this PR is not ready to be reviewed. Please read the [CONTRIBUTING](https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md) guidelines -- specifically the ["Before submitting a pull request"](https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md#before-submitting-a-pull-request) section...

Reviewers: @tiainen @kevinrushforth /reviewers 2

@johanvos do you also want to review or is Joeri's review OK?