jfx icon indicating copy to clipboard operation
jfx copied to clipboard

8329011: Update SQLite to 3.45.3

Open HimaBinduMeda opened this issue 1 year ago • 8 comments
trafficstars

Update SQLite to v3.45.3.Verified build on all platforms. Sanity testing looks fine.


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [x] Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1454/head:pull/1454
$ git checkout pull/1454

Update a local copy of the PR:
$ git checkout pull/1454
$ git pull https://git.openjdk.org/jfx.git pull/1454/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1454

View PR using the GUI difftool:
$ git pr show -t 1454

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1454.diff

Webrev

Link to Webrev Comment

HimaBinduMeda avatar May 14 '24 11:05 HimaBinduMeda

:wave: Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar May 14 '24 11:05 bridgekeeper[bot]

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8329011: Update SQLite to 3.45.3

Reviewed-by: sykora, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk[bot] avatar May 14 '24 11:05 openjdk[bot]

Webrevs

mlbridge[bot] avatar May 14 '24 12:05 mlbridge[bot]

Reviewers: @tiainen @kevinrushforth

/reviewers 2

kevinrushforth avatar May 14 '24 13:05 kevinrushforth

@johanvos do you also want to review or is Joeri's review OK?

kevinrushforth avatar May 14 '24 13:05 kevinrushforth

@kevinrushforth The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

openjdk[bot] avatar May 14 '24 13:05 openjdk[bot]

@johanvos do you also want to review or is Joeri's review OK?

In Joeri I trust :)

johanvos avatar May 14 '24 14:05 johanvos

In Joeri I trust :)

Me, too. :)

kevinrushforth avatar May 14 '24 14:05 kevinrushforth

/integrate

HimaBinduMeda avatar May 15 '24 15:05 HimaBinduMeda

Going to push as commit 581e3a70a45a550a97e391e06735f4837336ada8.

openjdk[bot] avatar May 15 '24 15:05 openjdk[bot]

@HimaBinduMeda Pushed as commit 581e3a70a45a550a97e391e06735f4837336ada8.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar May 15 '24 15:05 openjdk[bot]