Kevin Rushforth
Kevin Rushforth
I pushed the following updates: - Added a utility to print an incubator warning - Updated the Incubator Modules JEP: - Change `javafx.incubator` to `jfx.incubator` - Say that a JEP...
> BTW, should we have a separate, real PR with changes _only_ for enabling the functionality (.md file and build.gradle, the latter with sample module changes commented out - maybe...
> @kevinrushforth kevinrushforth force-pushed the javafx.incubator branch from 1f567a9 to 4bb1b59 now I pushed the wrong merge commit, so corrected it before (I hope) anyone other than Skara noticed. I...
@lukostyra would be another good reviewer of this.
I did a first pass of the updated PhongMaterial docs. Nice work! I'll need more time to go through it in detail (and definitely will want Ambarish and Lukasz to...
Thank you for generating new images. Some of the new files are quite large, and the total added storage is 35 Mbytes, which is a lot for binary image files...
I looked at the images in the javadoc-generated web page, and the rendered image size looks good. I recommend scaling most of the images down by at least a factor...
Btw, if this ends up missing the deadline for JavaFX 22 (about 24 hours from now) it can go into 22u for JavaFX 22.0.1. The release date for 22.0.1 is...
> > One other thing I noticed is that the file names have spaces in them, which is not a best practice and causes problems for scripts. Can you change...
The images look good. I'll do a final pass on the docs.