Kevin Rushforth
Kevin Rushforth
The addition of the compile-time flags looks OK. I did a build with GTK 3.22 (so it compiles the new code, does the dlsym, and does the runtime check) and...
This dropped off my radar. The only pending issue is the test failure I noted in an earlier comment: > I then did a full test run on our headful...
@tsayao can you re-review?
Hmm. There was a reason we added a return value to `_enterNestedEventLoop`, but I'll take a closer look. Have you run all of the headful tests? /reviewers 2
@Maran23 Please merge in the latest upstream master, since your branch is out of date.
@Maran23 I see from the description that you tested this on mac. How did you test it? Did you run with `-PFULL_TEST=true`?
> maybe it's time to setup a VM on my Windows machine. Are there any recommendations I may should follow for the setup? :-) I don't know of any supported...
I see the same failure with the most recent patch as I did yesterday. I looked over the changes, and I'm not convinced that this is the right approach. One...