J. David Ibáñez comments

Results 85 comments of


                                            J. David Ibáñez

index: map git_index_conflict_add

Ah didn't scroll to the bottom. That test message is actually not correct, it was later identified to be an issue related to the filesystem, not the os, see https://github.com/libgit2/pygit2/pull/1329#issuecomment-2599690561...

AttributeError: cffi library 'pygit2._libgit2' has no function, constant or global variable named 'git_remote_save'

Good catch, the method was added in 2014 but libgit2 removed git_remote_save in 2015 (v0.23). There was not a unit test for it so it went unnoticed. This is what...

typecheck-part-1

Thanks @DinhHuy2010 for the contribution. And thanks @Tsafaras for the review, I agree with the comments. Regarding select/ignore, it should be more specific. I've pushed a commit where just the...

Python 3 port uses Unicode to represent byte strings

In the latest release we're using `PyUnicode_DecodeFSDefault()` and `PyUnicode_EncodeFSDefault()` It remains to use `os.fsdecode()` (PRs welcome).

random fixes

Hi, this PR is too big, could you split it?