J. David Ibáñez
J. David Ibáñez
The release can wait a little bit. There's a new version of libgit2, so I'll try to upgrade for the next release (though first https://github.com/libgit2/libgit2/issues/6519 has to be fixed).
Since this issue was opened type hints have been added to the C extension. For further improvements please open a PR.
Uploaded manually. Still remains to fix the automatic upload from AppVeyor, to do for the next release.
It looks good, but the tests don't pass on Windows: https://ci.appveyor.com/project/jdavid/pygit2/builds/49936765/job/72q19bou1q95mxy9
Thanks for the excellent report in libgit2 I think we can just skip the test on Windows, with a reference to the libgit2 issue, and then merge the PR.
The PR is straightforward and the error is clearly in the libgit2 side. What you propose is in the best interest of users, yet I'm not sure we should workaround...
By the way you have been the largest contributor to pygit2 since you started few years ago, about half the contributions no less. Also your contributions have been of an...
It's an import error. From what I see this has been fixed already in scmrepo 2.1.1 For the record, the old constants are still available in the root package: from...
Reading cffi's documentation, centries will be garbage collected, so there is nothing to do with it.
> Interesting that it failed for macos (and that the feedback already tips that it might be a problem in libgit2). What do you mean? I don't see a clue...