J. David Ibáñez comments

Results 85 comments of


                                            J. David Ibáñez

test_no_context_lines fails on Big Endian

There have been major releases of libgit2 (0.99) and pygit2 (1.1); can you try? Such a low level issue is more likely to be from libgit2, so it may be...

test_no_context_lines fails on Big Endian

For the record I've added s390x to Travis and it's still failing, https://travis-ci.org/github/libgit2/pygit2/jobs/741338976#L1507

test_no_context_lines fails on Big Endian

In PR #1130 @roehling has fixed a bug related to big endian. Maybe this is the same kind of issue. If someone wants to check...

ValueError `repo.branches.get('branch_no_exist/')` trailing slashes in branch names

This looks related to issue #828 If branch names are not allowed to have slashes then it should fail with an informative error, probably `InvalidSpecError` since PR #829 ; did...

repo.walk in thread hangs the main thread

That's not the behaviour I observe. If you replace `list(...)` by the for loop you will see many prints. In other words, it's `list` which is blocking, not pygit2. And...

Consistent interface to get text and bytes

If I'm not missing anything.. These are the places where we use `.data`: - `Blob.data` - `Patch.data` These are the places where we use `.raw`: - `Oid.raw` With `read_raw()`: -...

Consistent interface to get text and bytes

Good point. No, this doesn't block the release. What I'd like to do before the next release is handling the pycparser issue, #846 The criteria for new releases is: not...

Consistent interface to get text and bytes

@jnrbsn Okay, noted. The fastest way to get something done is to make a PR.

Does pygit2 implements 'git push --mirror'?

No, I think it's not implemented. PRs welcome.

Index.getitem breaks with bytes on Python 3

We don't support Python 2 any more. Which is the real use case to accept bytes? Maybe there're index files out there that don't use UTF-8?