J. David Ibáñez

It would be a lot like `Repository_cherrypick` https://github.com/libgit2/pygit2/blob/master/src/repository.c#L674 but with more arguments, and it would return an index object like `merge_trees` does https://github.com/libgit2/pygit2/blob/master/pygit2/repository.py#L791 If you want to do a PR...

I'd like to thank @ddevault , the 1st pygit2 sponsor :tada: Check his https://sourcehut.org/ software development platform.

yes you're right, it may be a good thing

hey! Just cloned the repo but that commit is not there: ```bash $ git clone https://git.sr.ht/~kvik/unionfs Cloning into 'unionfs'... remote: Enumerating objects: 143, done. remote: Counting objects: 100% (143/143), done....

But it can be reproduced: ```python from pygit2 import Repository repo = Repository('issue947/test') repo.get(repo.head.target) Traceback (most recent call last): File "issue947.py", line 3, in repo.get(repo.head.target) File "/home/jdavid/sandboxes/pygit2/pygit2/repository.py", line 125, in...

My concern is that building the patch would be a waste of time if the flags are not used later. The alternative would be to build the patch lazily, when...

Looks good, can you please add the unit tests?

I think you're right about at least some of the bugs, ping @ddevault since he's the author of this code. For the 3rd one I think the link is not...

+1 if integration with Travis is added

We don't support Python 2 any more, so this should be easier. The minimum required version is Python 3.5 Anyway this should be contributed (PR), or funded (sponsored). For reference,...