J. David Ibáñez

Results 85 comments of J. David Ibáñez

Yes, but instead of 1 big PR, I'd prefer a number of smaller PRs (Today the minimum supported version of Python is 3.7)

First I should look about having the docs published for more than 1 version of pygit2. Then updating automatically should not be much work.

This would be very nice. Maybe you can make a branch and let AppVeyor build, see whether it works with VS 2015? I know very little about Windows, maybe @fourplusone...

Cool, I think it's still worth building with libssh2. Ideally I think libgit2 should provide binaries for Windows, so bindings don't have to. This would avoid duplicating the work in...

Thanks @ethomson for the feedback. Actually we're statically linking libssh2 in Linux wheels. I'd rather do the opposite of what we do now: drop libssh2 from the Linux wheels and...

Ok, let's keep the current status quo then. Just have to add libssh2 to the Windows wheels. No idea about the `socket disconnect` error though.

Let's see an exemple. Today we have: ```python err = C.git_clone(crepo, to_bytes(url), to_bytes(path), opts) check_error(err) ``` The proposal is to write: ```python GitException.check_result(C.git_clone)(crepo, to_bytes(url), to_bytes(path), opts) ``` Today's code already...

Okay. The callback code was contributed long time ago by someone else, I myself didn't know exactly how it worked. So I've reviewed it and done some commits. It's all...

Our `Tag` object is an annotated tag, so it's correct that it inherits from `Object`. So what you propose is to add a new object for regular tags, which would...

Not exactly. From libgit2, https://libgit2.org/libgit2/#HEAD/group/reference/git_reference_is_tag > 1 when the reference lives in the refs/tags namespace; 0 otherwise. For a reference tag that points to a commit `Reference.is_tag` will return true,...