J. David Ibáñez

Results 85 comments of J. David Ibáñez

By the way I just removed `Reference.get_object()` which has been deprecated for over 4 years.

Not really, if the tag points to a tag object such as `tag -> tag object -> commit` then `Reference.peel(None)` will return the commit object, while `Repository[Reference.target]` will return the...

okay to `.get()` It would be equivalent to: repo[ref.resolve().target]

We don't support Python 2 any more. Still we should handle the name and the email the same way. In my opinion the name should use ``s`` as well, and...

I think that time granularity is 1 second, so if increasing ``time.sleep`` to 1s it should work, but it doesn't. Looking at the repo all commits have the same time....

The time is part of the signature, it's set when the author and committer are defined. See https://github.com/libgit2/pygit2/blob/master/src/signature.c#L58

Do you mean version 0.24 has the same behaviour? Before you stated it did not.

Yes let's do that.

Sure, this is already done in some places, check calls to `pgit_encode*` (this is defined in `src/utils.c`) PRs welcome.