Edward Faulkner
Edward Faulkner
Maybe a reasonable compromise on `@controller` is to make it work but make it clear that nobody is being told to refactor to that pattern. So it won't be a...
`settled` doesn't capture native Promises. This is true in general for everything that uses native promises, including untranspiled `async function` and native `fetch`. However, we could call `registerWaiter` from inside...
Discussed in tooling meeting, this seems fine and can move ahead when it has passing tests.
Your repro link is broken and this is not enough information to say what's going wrong. There are known module-duplication bugs that effect ember-source that are fixed only in the...
I merged https://github.com/emberjs/ember.js/pull/20782 so this needs conflict fixes.
@mansona I fixed the particular tests that we were looking at. There are other tests that need cleanup now. For example "Scenario 4" is assuming that it will see a...
We just fixed a very similar case in https://github.com/ef4/ember-auto-import/pull/530 by moving an error from build time to runtime. It would make sense to do the same for `importSync` for the...
> The primary difference between Glimmer's view of plugin and Ember's is > that Ember extends this API to allow plugins to create bindings in the > compiled JavaScript module....
If the classic build doesn't do that then it's a bug. We mostly try to leave the classic style pipeline unchanged under embroider.
Iterating all the files at runtime implies that all the files were forced to load into the browser. Which we don't want to commit to doing. I don't fully understand...