Edward Faulkner

As far as I know, stable embroider releases work with inspector up to ember 6.1. I don't think we need to back port a new feature very far. Also I...

Check whether this is an unintended side-effect of `classicEmberSupport()`. It's supposed to be merging `build.target` into the config, but it could conceivably be stomping default behavior.

(I'm assuming the vite default behavior is supposed to do this, without asking.)

We might want to style `classicEmberSupport()` more like `ember()`, such that its config hook mutates the config rather than returning a partial config and trusting vite to do the merge....

Can we make this package just an implementation detail of eslint-plugin-ember? Given that all template logically exist inside JS now. From the user's perspective, it's weird to need two different...

I think it would be good if we can emit the warning. The explanation we should give people for why you can't use `{{rootURL}}` is that the meaning of all...

Discussed this at embroider office hours, the next action suggestion is to try reproducing this in a plain webpack project first to rule that out. You can find the style...

> I am just curious, why we don't import app.css to a javascript file and then stylePlugins and styleLoaders would deal with styles? This is because we're trying to be...

vendor.js has to remain a script, not a module. That's why it continues to exist as a separate thing. All the code in it expects to run in script context.

The implementation changes look good. For the test, I'd rather not maintain a whole separate matrix full of tests for this case. Can we perhaps add an additional `basePath` argument...