Edward Faulkner

I created a minimal reproduction of this bug in esbuild: https://github.com/evanw/esbuild/issues/3976 The summary is, esbuild knows to consider certain paths "disabled" by the `browser` entry in package.json, but it hides...

The reason for this rule is not different in tests vs app. So if we think this rule is unworkable in tests and safe to disable in tests, we should...

This is not related to #2168. That bug is about the top-level `browser` field in package.json. This bug is about `browser` *inside* package.json `exports`.

I commented here https://github.com/emberjs/ember-cli-babel/issues/442#issuecomment-2894738580 But the path forward for people hitting this is to stop using the `includeExternalHelpers` feature. It's not enabled by default. If you (or one of your...

Notes from meeting discussion: - @embroider/core and @embroider/compat don't really support node < 20, their engine declarations are out of date. - @embroider/macros and @embroider/shared-internals are special and those *do*...

This got superseded, virtual-entry point now watched the whole app dir.

I paused working on this to go fix some circular imports in ember itself, which were blocking several of the things here I was trying to debug.

Picking this up on a new branch.

I also saw this failure recently, it was due to [ember-composable-helpers](https://github.com/DockYard/ember-composable-helpers/blob/62fb18314e563d70c6588d733df4d26fd4b14aa1/lib/strip-bad-reexports.js#L25C31-L25C40). ember-cli-babel itself has been ignoring a babel config for quite a long time. I don't think we should hide...

> But we're already in a place where types are lying, you can't assume that we always have a filename because babel can be run on a string representation of...