ember.js
ember.js copied to clipboard
emberjs
Inplement runtime portion of RFC #931
Safari 17.6 passes locally for me. I see that browserstack is using Safari 12 (we did for 5.x). We don't actually support that.
According to: https://browsersl.ist/#q=%3E+0.25%25+and+not+dead per: https://emberjs.com/browser-support/
I think we can bump to Safari 15.6
PR: https://github.com/emberjs/ember.js/pull/20779
I tried this out in an embroider app here: https://github.com/NullVoxPopuli/ember-source-pr-20776-testing
and it didn't work (seems like nothing is rendered?).
maybe whatever is going on with CI will be resolved when this reproduction is resolved?
Looks like there are two copies of @glimmer/manager now, which breaks setComponentTemplate.
Supposedly, I have sourcemaps turned off
Your repro link is broken and this is not enough information to say what's going wrong. There are known module-duplication bugs that effect ember-source that are fixed only in the very latest main of embroider.
Your repro link is broken and this is not enough information to say what's going wrong.
I don't understand, the link works. Also, all templates are just.. not rendered (which I said 🤔 ).
Unless you mean something more specific?
There are known module-duplication bugs that effect ember-source that are fixed only in the very latest main of embroider.
in any case, I suppose for this feature we don't want to fix for embroider3? which means we have to disable/skip the failing test?
I confirm things work as expected in the vite blueprint:
code here: https://github.com/NullVoxPopuli/ember-source-pr-20776-testing-vite
What not-working looks like in these tests
code here: https://github.com/NullVoxPopuli/ember-source-pr-20776-testing
I merged https://github.com/emberjs/ember.js/pull/20782 so this needs conflict fixes.