Edward Faulkner

Results 676 comments of Edward Faulkner

If we want this problem to be less confusing, I would be in favor of making our babel plugins throw early if filename is undefined, with a message explicitly about...

As an alternative workaround, if we only want to patch the callsite of remove-types and not remove-types itself, we can wrap it in a `chdir` to ensure that it won't...

We should probably figure out what the realistic upgrade paths are that we want to support. It will depend on which exact releases people find hard to upgrade across. It...

Digging in, I realize this also means we change the timing of class property initialization. (I realize maybe I am late to the party and I vaguely recall people talking...

I see. Ok. Is there any manual workaround that allows an app author to make a property that's enumerable while also being tracked?

Yes it’s still relevant. I think it’s better if people who hit this problem can find an open issue about it, rather than opening new issues.

3.0 changes the constructor arguments to `ImportUtil`. Like: ```diff -state.importer = new ImportUtil(babel.types, path); +state.importer = new ImportUtil(babel, path); ```

I think `type="module"` is a red herring here. I just confirmed that in a stock `@embroider/vite` app subpath imports work out of the box for both the app's own code...

`Embroider/Vite (main)` v1 Addon should work as long as we're using BROCCOLI_ENABLED_MEMOIZE the same way stable does, we should confirm that. `Embroider/Webpack (future IoC)` will just work. v2 addon and...

Under the classic build, those `.hbs` files work as **both** components and route templates. For example, if `app/templates/components/example.hbs` exists you can do both `` and `transitionTo('components/example')`. This is a pretty...