Edward Faulkner

Results 676 comments of Edward Faulkner

No, I don't think this is a good idea. Either we support this case or we don't. If we do, then we should just drop the assertion entirely as in...

I'll take a look. (My first impression of the benchmarking suite: it sure is tied to the non-ES-modules way of doing things that we're trying to deprecate.)

The global event dispatcher was also the thing I was referring to when I said maybe we don't need the assertion anymore. I didn't remember that we still have it.

It sounds like we would need an optional feature here. Because you'd want a way for people who've opted into never using the event dispatcher to avoid seeing a warning....

Fixed in https://github.com/ember-cli/ember-cli/pull/10685

More investigation on this: This is annoying but not actually a correctness issue. Glimmer component arguments work the same way HTML attributes do, which is that a missing value is...

The problem right now is that at the level of the glimmer parser and printer, arguments and attributes are the same thing. So if we decided that `@foo=""` is better...

My original intent with this list in the readme was to only highlight a few of the important switches that you need to get correctness or to plan what upgrades...