Remove unneeded restriction around creating sub-applications

[NullVoxPopuli]

A path to unblocking:

• https://github.com/NullVoxPopuli/limber/pull/1925
  • This Limber PR has a patch of the change in this EmberJS PR

While working new repl infra for https://limber.glimdown.com, I want to take a more "islands" approach, like https://astro.build -- it enables a ton of power -- however, there is an assertion that prevents using nested applications -- which kinda feels silly since we allow it via "engines".

Like with how we use modifiers and 3rd party libraries that manage DOM, whenever we use an element that has some external control of its descendents, we must make the same assumptions and allowances --- generally this is safe, as once we let 3rd party scripts manage their subtree, ember doesn't mess around in there (because when someone would instruct ember to mess around in someone else's subtree, that's when you run in to problems -- but this is easy enough to avoid).

In my use case, I have:

• host ember app (could be any other app though, even react)
  • run through repl stuff
    • be given an element to put somewhere
      • render that element
        • in my case for https://limber.glimdown.com, the element is rendered via a component. so this component is mounting a whole new app, and nothing is is going to mess with the subtree.
          This works via using the new template() API for the runtime compiler:

          const element = await compiler.compile('gjs', code);
          
          component = template(`{{element}}`, { scope: () => ({ element }) });
          

[github-actions[bot]]

Estimated Asset Sizes

Diff

Details

This PR

main

╔═══════╤═══════════╤═══════════╗ ║ │ Min │ Gzip ║ ╟───────┼───────────┼───────────╢ ║ Total │ 408.84 KB │ 228.88 KB ║ ╚═══════╧═══════════╧═══════════╝ ╔══════════════════════╤═══════════╤══════════╗ ║ @ember/* │ Min │ Gzip ║ ╟──────────────────────┼───────────┼──────────╢ ║ Total │ 239.23 KB │ 147.2 KB ║ ╟──────────────────────┼───────────┼──────────╢ ║ -internals │ 35.44 KB │ 25.49 KB ║ ║ application │ 12.83 KB │ 7.62 KB ║ ║ array │ 12.66 KB │ 7.32 KB ║ ║ canary-features │ 304 B │ 419 B ║ ║ component │ 1.07 KB │ 1004 B ║ ║ controller │ 1.8 KB │ 1.36 KB ║ ║ debug │ 11.4 KB │ 7.92 KB ║ ║ deprecated-features │ 31 B │ 77 B ║ ║ destroyable │ 561 B │ 383 B ║ ║ enumerable │ 259 B │ 387 B ║ ║ helper │ 823 B │ 570 B ║ ║ instrumentation │ 2.43 KB │ 1.78 KB ║ ║ modifier │ 669 B │ 614 B ║ ║ object │ 33.78 KB │ 20.79 KB ║ ║ owner │ 159 B │ 178 B ║ ║ renderer │ 385 B │ 327 B ║ ║ routing │ 58.05 KB │ 33.43 KB ║ ║ runloop │ 2.2 KB │ 1.33 KB ║ ║ service │ 859 B │ 741 B ║ ║ template │ 430 B │ 390 B ║ ║ template-compilation │ 429 B │ 366 B ║ ║ template-compiler │ 57.81 KB │ 30.44 KB ║ ║ template-factory │ 94 B │ 160 B ║ ║ test │ 923 B │ 627 B ║ ║ utils │ 3.93 KB │ 3.5 KB ║ ║ version │ 55 B │ 131 B ║ ╚══════════════════════╧═══════════╧══════════╝ ╔═════════════════╤═══════════╤══════════╗ ║ @glimmer/* │ Min │ Gzip ║ ╟─────────────────┼───────────┼──────────╢ ║ Total │ 169.61 KB │ 81.68 KB ║ ╟─────────────────┼───────────┼──────────╢ ║ destroyable │ 2.7 KB │ 1.35 KB ║ ║ encoder │ 596 B │ 653 B ║ ║ env │ 38 B │ 87 B ║ ║ global-context │ 886 B │ 545 B ║ ║ manager │ 12.19 KB │ 5.44 KB ║ ║ node │ 2.71 KB │ 1.81 KB ║ ║ opcode-compiler │ 29.89 KB │ 13.23 KB ║ ║ owner │ 159 B │ 202 B ║ ║ program │ 7.1 KB │ 3.63 KB ║ ║ reference │ 5.51 KB │ 3.18 KB ║ ║ runtime │ 95.26 KB │ 42.51 KB ║ ║ tracking │ 989 B │ 961 B ║ ║ util │ 3.03 KB │ 2.29 KB ║ ║ validator │ 6 KB │ 3.72 KB ║ ║ vm │ 784 B │ 798 B ║ ║ wire-format │ 1.84 KB │ 1.35 KB ║ ╚═════════════════╧═══════════╧══════════╝

╔═══════╤═══════════╤═══════════╗ ║ │ Min │ Gzip ║ ╟───────┼───────────┼───────────╢ ║ Total │ 408.84 KB │ 228.88 KB ║ ╚═══════╧═══════════╧═══════════╝ ╔══════════════════════╤═══════════╤══════════╗ ║ @ember/* │ Min │ Gzip ║ ╟──────────────────────┼───────────┼──────────╢ ║ Total │ 239.23 KB │ 147.2 KB ║ ╟──────────────────────┼───────────┼──────────╢ ║ -internals │ 35.44 KB │ 25.49 KB ║ ║ application │ 12.83 KB │ 7.62 KB ║ ║ array │ 12.66 KB │ 7.32 KB ║ ║ canary-features │ 304 B │ 419 B ║ ║ component │ 1.07 KB │ 1004 B ║ ║ controller │ 1.8 KB │ 1.36 KB ║ ║ debug │ 11.4 KB │ 7.92 KB ║ ║ deprecated-features │ 31 B │ 77 B ║ ║ destroyable │ 561 B │ 383 B ║ ║ enumerable │ 259 B │ 387 B ║ ║ helper │ 823 B │ 570 B ║ ║ instrumentation │ 2.43 KB │ 1.78 KB ║ ║ modifier │ 669 B │ 614 B ║ ║ object │ 33.78 KB │ 20.79 KB ║ ║ owner │ 159 B │ 178 B ║ ║ renderer │ 385 B │ 327 B ║ ║ routing │ 58.05 KB │ 33.43 KB ║ ║ runloop │ 2.2 KB │ 1.33 KB ║ ║ service │ 859 B │ 741 B ║ ║ template │ 430 B │ 390 B ║ ║ template-compilation │ 429 B │ 366 B ║ ║ template-compiler │ 57.81 KB │ 30.44 KB ║ ║ template-factory │ 94 B │ 160 B ║ ║ test │ 923 B │ 627 B ║ ║ utils │ 3.93 KB │ 3.5 KB ║ ║ version │ 55 B │ 131 B ║ ╚══════════════════════╧═══════════╧══════════╝ ╔═════════════════╤═══════════╤══════════╗ ║ @glimmer/* │ Min │ Gzip ║ ╟─────────────────┼───────────┼──────────╢ ║ Total │ 169.61 KB │ 81.68 KB ║ ╟─────────────────┼───────────┼──────────╢ ║ destroyable │ 2.7 KB │ 1.35 KB ║ ║ encoder │ 596 B │ 653 B ║ ║ env │ 38 B │ 87 B ║ ║ global-context │ 886 B │ 545 B ║ ║ manager │ 12.19 KB │ 5.44 KB ║ ║ node │ 2.71 KB │ 1.81 KB ║ ║ opcode-compiler │ 29.89 KB │ 13.23 KB ║ ║ owner │ 159 B │ 202 B ║ ║ program │ 7.1 KB │ 3.63 KB ║ ║ reference │ 5.51 KB │ 3.18 KB ║ ║ runtime │ 95.26 KB │ 42.51 KB ║ ║ tracking │ 989 B │ 961 B ║ ║ util │ 3.03 KB │ 2.29 KB ║ ║ validator │ 6 KB │ 3.72 KB ║ ║ vm │ 784 B │ 798 B ║ ║ wire-format │ 1.84 KB │ 1.35 KB ║ ╚═════════════════╧═══════════╧══════════╝

[NullVoxPopuli]

From two Chrises:

• global event dispatcher may get in the way here

[NullVoxPopuli]

Related: https://github.com/emberjs/rfcs/pull/1102

If we block this PR on the removal of the global event dispatcher, then this can't land until v7 at the latest.

I'm not sure we need to do that though, because it's a "protection", if anything

[kategengler]

I think it is fine to merge this so long as you can confirm nested apps work as expected. Is the EventDispatcher still used for events on Input and TextArea etc?

Also that RFC should be a deprecation RFC

[NullVoxPopuli]

Also that RFC should be a deprecation RFC

I copied the deprecation template :see_no_evil:

[kategengler]

Also that RFC should be a deprecation RFC

I copied the deprecation template 🙈

Sorry about that -- it looked different to me

[ef4]

The global event dispatcher was also the thing I was referring to when I said maybe we don't need the assertion anymore. I didn't remember that we still have it.

[kategengler]

@ef4 Could we solve this for now by changing the assert to a warn that mentions the remaining things that may need the global event dispatcher?

[ef4]

It sounds like we would need an optional feature here. Because you'd want a way for people who've opted into never using the event dispatcher to avoid seeing a warning.

A single optional feature could:

• disable the global event dispatcher
• remove the assertion as in this PR
• make all the things that would have relied on the global event dispatcher throw instead

[kategengler]

I think we'd want that if we were to actually deprecate the event dispatcher, but in this case, it would only warn when you create nested applications, which would enable @NullVoxPopuli's explorations.

[NullVoxPopuli]

changed to warn here: https://github.com/emberjs/ember.js/pull/20915 -- this will allow me to remove my patch in the new REPL stuff i'm working on