Michael Crenshaw

Results 666 comments of Michael Crenshaw
trafficstars

Just encountered it an Intuit for (afaik) the first time. A force refresh and controller restart cleared the error. Argo CD version: v2.4.6 Kubernetes provider: EKS Kubernetes version: v1.21.12-eks-a64ea69

I've given up on doing codegen locally right, and now I just copy and paste from the failed check's diff. :-P

@notfromstatefarm can you resolve that conflict?

@jmmclean have you been able to validate that the fix works for you?

@nicolas-vivot I believe Argo CD constructs the tree based on `metadata.ownerReferences`. Is that populated in the ClustExternalSecret resource?

Can't you nest maps? If so, I feel like the loop is effectively unbounded. ``` map(0..10000, {map(0..10000, {map(0..10000, {sprig.genPrivateKey('rsa')}}} ```

Ah. So the map limit is cumulative. I can see that a million triggers the limit: ``` > map(0..999, {map(0..999, {"a"})}) panic: memory budget exceeded (1:14) > map(0..998, {map(0..999, {"a"})})...

I'm worried that memory cost estimation might be prohibitively difficult because cost might be heavily contingent on parameters. As a simple example, `sprig.genPrivateKey` will generate different-length keys for different key...

Could this be achieved by adding a branch name filter to the SCM provider generator? https://github.com/argoproj/applicationset/blob/master/docs/Generators-SCM-Provider.md#filters

@adamjohnson01 thanks for the explanation! I don't think I'll be able to give this the review it deserves until Monday. Thanks for your patience!