Michael Crenshaw
Michael Crenshaw
Oh! For an out-of-bounds field edit test, try this: ``` { name: "the output application structure is imutable", fieldVal: "{{ .yamlPiece }}", expectedVal: "some-value\n chart: some-other-chart", templateOptions: &argoprojiov1alpha1.ApplicationSetTemplateOptions{ GotemplateEnabled: true,...
With the above test, I can actually force `chart` to have the value `some-other-chart` for some values of `fieldName` in the test. ``` Error Trace: util_test.go:398 Error: Not equal: expected:...
Okay, I did my reading. :-) ## Use cases Use cases which only require string templating: * Regex replacements in variables to make valid `name` values (https://github.com/argoproj/applicationset/issues/518, https://github.com/argoproj/applicationset/issues/447, https://github.com/argoproj/applicationset/issues/351) *...
In the back of my mind, I have this idea of duplicating the Application structure, replacing certain non-string fields with `JSON` fields and then letting the unmarshaller/templater figure out how...
Sounds good! My main concern about #362 is that, if the template is YAML-formatted, my template must also be valid JSON. For example, I couldn't do this: ```yaml spec: source:...
@vavdoshka with Jonathan's comments in mind, I'd recommend going ahead with full text-field templating. At some point I'd like to explore per-field templating for users who need more control over...
@vavdoshka that's fantastic! My only suggestion would be that we use something besides `{{=` to avoid confusion with Workflows, which uses expr to evaluate the contents. I'm not particular, something...
@vavdoshka if you want to just push what you have, I can try to get it across the finish line!
@rishabh625 is this on your TODO list? No worries if not, you've got plenty on your plate. Just want to give @zbialik a status update. :-)
Looking forward to seeing what direction Workflows goes with this. I'd like to add some more templating capabilities to ApplicationSet (in a backwards-compatible way). Maybe supporting text/template at the field...