Michael Crenshaw

Results 648 comments of Michael Crenshaw

@pdrastil that's true... the existing parser adds support for `d`, which I don't think is supported by `time.ParseDuration`.

Although we do use `time.ParseDuration` for a lot of other stuff, so I definitely think it's worth switching eventually. Just maybe by toggling on the presence of a `d` to...

I like that solution! I see four places in the code using that utility function. To be honest, I'd rather copy/paste the function into Argo CD and modify it than...

Just chatted with someone who wants to pass not just a values file but also files-as-values using `--set-file name=/path`. Seems reasonable to support external `--set-file`s along with `--values` files.

We should probably also consider whether the external values source should be able to also set a Helm targetRevision. That would be helpful in cases where a devops team wants...

Ishita has opened a [proposal PR](https://github.com/argoproj/argo-cd/pull/8322) for this feature. Reviews are appreciated!

> IMHO this should be broken up. External values files support in Helm - is a sub-part of that proposal - and IMHO should be added seperately. @KlavsKlavsen I had...

> I assume multiple app sources, would have to be like merging arrays - you need to decide WHICH has precedence - if 2 definie the same object - or...

Thanks, @Marvin9! What if, instead of darkening the "active" buttons and adding a small green checkmark, we just added a proper square checkbox to the left of each icon (inside...

I like it! Will wait for UI folks to weigh in. :-)