Michael Crenshaw
Michael Crenshaw
@speedfl I made a few of the changes I requested and put them here: https://github.com/argoproj/argo-cd/pull/10163 For some reason it wouldn't let me open a PR directly against your branch.
> For the RBAC change (which has not yet been made), I was twisting my head. I see two possible options to extend the RBAC syntax to address applications: >...
> I think the small breaking change in add the / as a seperator is also worth it. This part I'm less certain about, because I think it would break...
We could 1) Introduce an optional `formatVersion` field to argocd-rbac-cm (defaulting to `v1` if not present) 2) Have `v2` opt them in to validating for fully-slashed RBAC format and enabling...
@FireDrunk I think you'll have to compile. I don't believe images in PRs are pushed anywhere. But the `make image` make target is very easy/reliable in my experience.
> I'm not sure if it should affect the ability to create applications in other namespaces... Maybe we can also implicitly assume v2 RBAC if that parameter is set? That...
@hobti01 that error seems legitimate to me. `{{path.basenameNormalized}}` should not appear in that error message unless variable substitution did not happen. In other words, `{{path.basenameNormalized}}` is unresolved.
@karlschriek can you check whether this might be a duplicate of either of these? * https://github.com/argoproj/argo-cd/issues/7437 * https://github.com/argoproj/argo-cd/issues/3517 If so, can we consolidate on one of those threads? The existing...
@able8 that seems consistent with what I found here: https://github.com/argoproj/argo-cd/issues/9558 I think that issue identifies the problem line of code. I don't have time to tackle it at the moment,...