Michael Crenshaw

After thinking some more, I'm still not comfortable inferring pattern type. 1) We can't be sure of the intent of someone who is currently using `**` in a pattern. It's...

I do like doublestar a lot more! Looks better-maintained. But I don't think it resolves the first three points. I've been using these tests to compare behavior: ```go func TestGlobVsMatch(t...

> this is limited to excludes and not the path generation as that is handled by git ls-files Can you clarify what you mean here? I'm sure I'm missing something...

Ah! Thanks for the clarification. Had to look at the code for a few minutes to understand what's happening. Yep, your idea of two different filter functions makes a lot...

@adamjohnson01 let us know if you'd rather us move over the PR on your behalf. :-)

@mlosicki this morning got taken up by another review. But I should have a chance to do a last pass review no later than tomorrow morning.

Yep! https://github.com/argoproj/argo-cd/pull/9049

Just a couple notes while you continue to work on this: 1. If we can timebox the template evaluations, we probably should. 2. We should probably remove particularly slow Sprig...

Another random thought: is it okay to run the template tool across the whole template, or should we recurse through the template and apply templates on a field-by-field basis? The...

@vavdoshka thanks for the detailed writeup! I'm still not sure where to go with the flexibility/predictability tradeoff. I'm going to spend some time reading the duplicate issues (https://github.com/argoproj/applicationset/issues/518, https://github.com/argoproj/applicationset/issues/447, https://github.com/argoproj/applicationset/issues/351,...