Michael Crenshaw

Added @rbreeze as a review. Remington, feel free to punt to another UI-capable person. :-)

Not actually ready for review, I just want to see if it'll generate a codecov diff for me.

I bet it was https://github.com/argoproj/argo-cd/security/advisories/GHSA-7943-82jg-wmw5. https://github.com/argoproj/argo-cd/issues/9424 wasn't (and won't be) backported to 2.4. Have you set `server.dex.server` in argocd-cmd-params-cm?

@ab-arao It's interesting that you had to set that. It should be the default: https://github.com/argoproj/argo-cd/blob/release-2.4/common/common.go#L17 The OIDC client in Argo CD's "session manager" includes a URL rewriter - each OIDC...

This is very very weird. I've seen one other case where the Dex URL seemed to change with no reason (in that case, the hostname changed as well, not just...

My bad, some of my links were to the latest code. Here's the file for the version you're running: https://github.com/argoproj/argo-cd/blob/v2.4.0/util/dex/dex.go The http/https switch is new for 2.5. It should always...

> What is even more interesting is that now this login process works regardless of whether the server.dex.server in argocd-cmd-params-cm is set to http or https. Yeah, that makes no...

I don't follow the last two. What does it mean to navigate to https://? Looks like you're already redirected to an https:// URL.

Possibly related: https://github.com/argoproj/argo-cd/issues/8820

@chetan-rns sorry, I let this one slip through the cracks. Can you resolve conflicts, and I'll review again?