go-grpc-middleware icon indicating copy to clipboard operation
go-grpc-middleware copied to clipboard

Published 20 hours ago • verified publisher icon grpc-ecosystem

Start using gorelease (https://godoc.org/golang.org/x/exp/cmd/gorelease)

Open bwplotka opened this issue 5 years ago • 4 comments

Pulled from https://github.com/grpc-ecosystem/go-grpc-middleware/issues/275 for visibility.

bwplotka avatar Oct 02 '20 09:10 bwplotka

This is a nifty tool. Can you elaborate on expected features?

gorelease -base=v1 tag -version=???

drewwells avatar Jan 18 '21 00:01 drewwells

Maybe @johanbrandhorst has ideas? I never used gorelease and also we don't build binaries in this project, so what we can leverage? (:

bwplotka avatar Jan 18 '21 19:01 bwplotka

gorelease is different from goreleaser, which builds binaries. gorelease maintains a compatibility promise. We use it in the grpc-gateway, and we could use it here too.

johanbrandhorst avatar Jan 18 '21 19:01 johanbrandhorst

I could see a few uses for this:

  • Evaluate compliance with v1 (is not required but is helpful for documentation)
  • Evaluate each new PR in v2 against v2 to determine if API promises were broken grpc-gateway does this

I'm guessing that the latter is the desired use of this tool. Since v2 is still undergoing API changes, we can't enforce this as a build check. So is the intention to add this as a new github action workflow that will get marked required after the API is settled?

drewwells avatar Jan 20 '21 02:01 drewwells