opentracing middleware: Add Option to put proto request in span for certain methods.

[bwplotka]

trafficstars

AC:

• We can enrich tracing in a generic way.

[jackskj]

If this issue is not in development, I can take a stab at it, it would come in handy.

[bwplotka]

Yes please help! Make sure you to actually do it on v2 branch which will be released soon. See: https://github.com/grpc-ecosystem/go-grpc-middleware/issues/275

Also I think we might need help in https://github.com/grpc-ecosystem/go-grpc-middleware/issues/277 which might more interesting to solve (:

[jackskj]

Oh I see, #277 seems like a it should be resolved before this issue. If it’s not assigned to anyone, I can migrate over to opentracing-go

[jackskj]

However, pushing entire request in the spawn may cause unnecessarily large amount of data collection. Do you think using field option is a worthy addition?

syntax = "proto3";
import "google/protobuf/descriptor.proto";
package tracing;
extend google.protobuf.FieldOptions {
    bool trace = 50000;
}

message MyMessage {
    string stuff = 1 [(tracing.trace) = true];
}

[bwplotka]

Well it depends on your method. Depends how big requests you have. (or responses). I would love to have this for certain methods (:

On Thu, 21 May 2020 at 18:10, Jack Juda [email protected] wrote:

However, pushing entire request in the spawn may cause unnecessarily large amount of data collection. Do you think using field option is a worthy addition? ` syntax = "proto3"; import "google/protobuf/descriptor.proto"; package tracing; extend google.protobuf.FieldOptions { bool trace = 50000; }

message MyMessage { string stuff = 1 [(tracing.trace) = true]; } `

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/grpc-ecosystem/go-grpc-middleware/issues/273#issuecomment-632230288, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVA3O63Z6J6JYDCUTIYO2DRSVOA3ANCNFSM4K3JV6IQ .