bruvzg

Results 238 comments of bruvzg

RTL is using `ResourceLoader::load(path)` to load images, it should be generic issue with reserved file names in `FileAccess`.

Most likely resource loader is adding `res://` to the name, and `is_path_invalid` it checking the whole path not a file name (so it's probably broken in most case).

Are you using HDR display and HDR enabled in the OS settings? I can reproduce it on HDR display on macOS, but not on SDR display. > Godot Desktop on...

Seems like some change in this PR broke multi-threaded renderer (both compatibility and Vulkan) on macOS (see https://github.com/godotengine/godot/pull/90268#discussion_r1554267653), but I'm not what's exactly wrong.

> We can't change theme constants to floats, it breaks compatibility What exactly is it breaking? I do not see anything this can break. > hinders their usability as booleans....

As a POC, switched theme constants to `Variant` with type annotation (it the constant declarations), and validation (on set/override, warning if set to wrong type value, error if value is...

> MO, we can change back to COINIT_MULTITHREADED and reopen the original Chinese input method not working problem, what's your opinion? IIRC, it was breaking more than just input. Also,...

> Regarding the issue of refresh rate appearing incorrectly, it looks like that Godot uses DEVMODEW [here](https://github.com/godotengine/godot/blob/5dc10b5aa506c4287c6ff87367efe031bc1a7d82/platform/windows/display_server_windows.cpp#L741) and this structure seems to used a DWORD for the storage of the...

> Are there any benefits to doing this other than less code? `pop_all` should be faster, but in real use cases it probably won't have any visible effect. The only...