Brian Quinlan

Results 168 comments of Brian Quinlan

> ping @brianquinlan 1. Are you sure that this is needed? Now that the final URL is available in `BaseResponse`, do we need a list of redirects? 2. If we...

> > 1. Are you sure that this is needed? Now that the final URL is available in `BaseResponse`, do we need a list of redirects? > > I believe...

Do the GMS and embedded versions track identically? If so, we can just replace "com.google.android.gms:play-services-cronet" with "org.chromium.net:cronet-embedded" in `prepare_for_embedded.dart` and leave the version unchanged.

I don't know the answer regarding dependabot.

Could you sign the contributer license agreement? https://cla.developers.google.com/.

> Thanks Brian. I already did. Does it need "signing" per pull request? No but I re-ran the presubmit and still see this error. Could you try again?

I think that the problem is that there are two contributors to this PR: PR Opener: @randomizedcoder Author: The se***n​@siden.io address has not signed the CLA.

The CLA check is still failing :-(