Brian Quinlan

Results 172 comments of Brian Quinlan

The problem is that `CupertinoClient` needs to control the `URLSession` delegate. Why do you want to reuse the `URLSession`?

> We are currently getting through a major version bump without too much difficulty, but that was a version bump without breaking API changes. cc @brianquinlan for thoughts on the...

@natebosch this is a less-breaking version of your change https://github.com/dart-lang/http/pull/699 My concern is that making this work only for `IOClient` will result in people writing more implementation-specific code. Maybe it...

> > My concern is that making this work only for `IOClient` will result in people writing more implementation-specific code. > > +1. I would be OK with a temporary...

> The redirects are still valuable for a response. I can add `finalUri` too. In dio, we also have a fork class for redirects and a field named `realUri`. Redirects...

> Please add redirects in IOStreamedResponse for workaround (#699) Then no breaking changes. > > With this, we can cast and then get redirect(final) url in specific usecase. There's better...

> > > Meanwhile, can we push splitting basic http classes from `io`? > > > > > > I don't know what you mean. > > One of the...

Another approach that we could define a mixins like: ```dart mixin FinalUrl on BaseResponse { abstract Uri? finalUrl; } ``` Users could consume it like: ```dart void main() async {...

> Please don't hesitate to make breaking changes. That would go against our general policy when developing packages ;-) > I'll try adding a new class for redirects and adding...

> > > I'll try adding a new class for redirects and adding `finalUri` too. > > > > > > How about just for `finalUri`? > > That would...