http icon indicating copy to clipboard operation
http copied to clipboard

`prepare_for_embedded.dart` should use a fixed Cronet version

Open brianquinlan opened this issue 1 year ago • 7 comments

prepare_for_embedded.dart updates build.gradle to use the latest version of Cronet.

This leads to the possible problem that the version of Cronet included in a release may not have been tested.

Instead, we should set an explicit version in prepare_for_embedded.dart.

brianquinlan avatar Jan 02 '24 20:01 brianquinlan

Any thoughts about this @AlexV525 ?

brianquinlan avatar Jan 02 '24 20:01 brianquinlan

It should be a corresponding version of the GMS version. Is the dependabot be able to do this?

AlexV525 avatar Jan 02 '24 23:01 AlexV525

Do the GMS and embedded versions track identically? If so, we can just replace "com.google.android.gms:play-services-cronet" with "org.chromium.net:cronet-embedded" in prepare_for_embedded.dart and leave the version unchanged.

brianquinlan avatar Jan 02 '24 23:01 brianquinlan

Do the GMS and embedded versions track identically? If so, we can just replace "com.google.android.gms:play-services-cronet" with "org.chromium.net:cronet-embedded" in prepare_for_embedded.dart and leave the version unchanged.

Unfortunately no

AlexV525 avatar Jan 03 '24 00:01 AlexV525

I don't know the answer regarding dependabot.

brianquinlan avatar Jan 03 '24 00:01 brianquinlan

Well that is just my idea. I'll do some investigation about it, before that we can find the correct version and apply it first.

AlexV525 avatar Jan 03 '24 01:01 AlexV525

@brianquinlan Are you able contact owners of Cronet to know about version mapping between GMS and non-GMS versions? https://chromium.googlesource.com/chromium/src/+/refs/heads/main/components/cronet/OWNERS

AlexV525 avatar Jan 03 '24 02:01 AlexV525