http
http copied to clipboard
`prepare_for_embedded.dart` should use a fixed Cronet version
prepare_for_embedded.dart updates build.gradle to use the latest version of Cronet.
This leads to the possible problem that the version of Cronet included in a release may not have been tested.
Instead, we should set an explicit version in prepare_for_embedded.dart.
Any thoughts about this @AlexV525 ?
It should be a corresponding version of the GMS version. Is the dependabot be able to do this?
Do the GMS and embedded versions track identically? If so, we can just replace "com.google.android.gms:play-services-cronet" with "org.chromium.net:cronet-embedded" in prepare_for_embedded.dart and leave the version unchanged.
Do the GMS and embedded versions track identically? If so, we can just replace "com.google.android.gms:play-services-cronet" with "org.chromium.net:cronet-embedded" in
prepare_for_embedded.dartand leave the version unchanged.
Unfortunately no
I don't know the answer regarding dependabot.
Well that is just my idea. I'll do some investigation about it, before that we can find the correct version and apply it first.
@brianquinlan Are you able contact owners of Cronet to know about version mapping between GMS and non-GMS versions? https://chromium.googlesource.com/chromium/src/+/refs/heads/main/components/cronet/OWNERS