Brian Quinlan

Results 168 comments of Brian Quinlan

What package are you referring to? `package:cronet_http`? `package:cupertino_http`? `package:http`? `package:web_socket`?

What exact tests would you want to be optional? Maybe you could create a PR to make them optional?

I'm not sure how to read the spec...do you not get a content-length header? Or does the browser correct it for you?

So the browser modifies "content-length" to match the actual number of decoded bytes in the body?

But then shouldn't it be possible to make the test fail? Because `content-length` == 100 but the body is empty? Like: ```dart if (responseHeaders['content-length'] case final contentLengthHeader?) { if (!_digitRegex.hasMatch(contentLengthHeader)...

Got it! Do you have access to the content-encoding header? Maybe we could limit the scope of the check to cases where content-encoding is not set?

Did you try declaring background modes for your application: https://developer.apple.com/documentation/foundation/url_loading_system/downloading_files_in_the_background?language=objc Maybe ["fetch"](https://developer.apple.com/documentation/xcode/configuring-background-execution-modes) would help?

Not all clients support setting a body in the 'GET' request.

Is there any reason why we shouldn't just point people to [fetch_client](https://pub.dev/packages/fetch_client)?

`package:fetch_client` implements the same `Client` interface as `package:http` so, aside from changing your `pubspec.yaml` and a few lines of configuration, your application should not have to change.