http headers comment

[randomizedcoder]

Additional comments to help with issue: https://github.com/dart-lang/http/issues/726

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[brianquinlan]

Could you sign the contributer license agreement? https://cla.developers.google.com/.

[randomizedcoder]

Thanks Brian. I already did. Does it need "signing" per pull request?

On Wed, Jan 3, 2024, 18:13 Brian Quinlan @.***> wrote:

Could you sign the contributer license agreement? https://cla.developers.google.com/.

— Reply to this email directly, view it on GitHub https://github.com/dart-lang/http/pull/1083#issuecomment-1876215611, or unsubscribe https://github.com/notifications/unsubscribe-auth/APMCHTW47SUKDDIKOIISEIDYMYF6DAVCNFSM6AAAAABAYVNZFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZWGIYTKNRRGE . You are receiving this because you authored the thread.Message ID: @.***>

[brianquinlan]

Thanks Brian. I already did. Does it need "signing" per pull request?

No but I re-ran the presubmit and still see this error. Could you try again?

[randomizedcoder]

It thinks I have signed

[image: image.png]

But gives an error when I click I agree

[image: image.png]

On Wed, Jan 3, 2024 at 9:30 PM Brian Quinlan @.***> wrote:

Thanks Brian. I already did. Does it need "signing" per pull request?

No but I re-ran the presubmit and still see this error. Could you try again?

— Reply to this email directly, view it on GitHub https://github.com/dart-lang/http/pull/1083#issuecomment-1876343973, or unsubscribe https://github.com/notifications/unsubscribe-auth/APMCHTWLGWFL6QVPDOSD7E3YMY47TAVCNFSM6AAAAABAYVNZFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZWGM2DGOJXGM . You are receiving this because you authored the thread.Message ID: @.***>

-- Regards, Dave Seddon +1 415 857 5102

[randomizedcoder]

Although maybe it did work, cos the "Date Signed" seems to be updated.

[image: image.png]

On Wed, Jan 3, 2024 at 9:43 PM dave seddon @.***> wrote:

It thinks I have signed

[image: image.png]

But gives an error when I click I agree

[image: image.png]

On Wed, Jan 3, 2024 at 9:30 PM Brian Quinlan @.***> wrote:

Thanks Brian. I already did. Does it need "signing" per pull request?

No but I re-ran the presubmit and still see this error. Could you try again?

— Reply to this email directly, view it on GitHub https://github.com/dart-lang/http/pull/1083#issuecomment-1876343973, or unsubscribe https://github.com/notifications/unsubscribe-auth/APMCHTWLGWFL6QVPDOSD7E3YMY47TAVCNFSM6AAAAABAYVNZFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZWGM2DGOJXGM . You are receiving this because you authored the thread.Message ID: @.***>

-- Regards, Dave Seddon +1 415 857 5102

-- Regards, Dave Seddon +1 415 857 5102

[brianquinlan]

I think that the problem is that there are two contributors to this PR: PR Opener: @randomizedcoder Author: <se***n​@siden.io>

The se***n​@siden.io address has not signed the CLA.

[randomizedcoder]

Ohhh. Maybe my git config is my work email. Sorry. Here you go.

[image: image.png]

On Thu, Jan 4, 2024 at 8:36 AM Brian Quinlan @.***> wrote:

I think that the problem is that there are two contributors to this PR: PR Opener: @randomizedcoder https://github.com/randomizedcoder Author: @.***>

The @.*** address has not signed the CLA.

— Reply to this email directly, view it on GitHub https://github.com/dart-lang/http/pull/1083#issuecomment-1877410261, or unsubscribe https://github.com/notifications/unsubscribe-auth/APMCHTWFNDO3XE5SMEMW2GDYM3LBRAVCNFSM6AAAAABAYVNZFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXGQYTAMRWGE . You are receiving this because you were mentioned.Message ID: @.***>

-- Regards, Dave Seddon +1 415 857 5102

[brianquinlan]

The CLA check is still failing :-(

[randomizedcoder]

I don't know mate. It's definitely signed.

I really don't care about attribution or anything, I was just trying to help some other person in future.

Maybe it would take you a couple of moments to just add this comment next time your pushing a change?