Brian Quinlan

Results 168 comments of Brian Quinlan

@seifibrahim32 I don't understand. `HttpHeader` and `HeaderValue` are defined in `dart:io` and should not appear in the public interface of `package:http`. In `package:http` the [headers are represented using a map](https://pub.dev/documentation/http/latest/http/BaseResponse/headers.html)....

> So you mean we inject the HeaderValue class away from http, isn't correct?, or make the HeaderValue loosely coupled or we separate it from Http , right? We can't...

@seifibrahim32 Do you still want to look at this issue?

Hi @aliaafreen, Unfortunately the web implementation of `Client` does not support streaming request data. If you are OK only supporting newer Chromium-based browsers then you could use [`package:fetch_client`](https://pub.dev/packages/fetch_client), which implements...

I'm assuming that this issue is being caused because the browser can't allocate enough memory to send the request so streaming the request would fix this.

@devoncarew I think that `package:fetch_client` already does this and there is no reason for us to step in. I could add stream as a feature in the [HTTP implementation comparison...

No, we have tests for much larger responses. Could you include some example code?

Setting `preserveHeaderCase: true` for `IOClient` seems reasonable to me. But this isn't something that we should require of clients because: 1. case insensitivity is required by RFC-2616 2. some clients...

If I had noticed that Flutter was affected, I would have added that fact the the **Impact** section of https://github.com/dart-lang/sdk/issues/53863 and forward-fixed it before landing my change. The problem is...

The reason that I want this is to provide a single place to that can link from the Dart API documentation when the idea of unhandled error/exception comes up. For...