Jacob Wujciak-Jens

Results 248 comments of Jacob Wujciak-Jens
trafficstars

I will think about this some more. For now lets post pone it after 0.2.0.

I restored the old behaviour of genOrdCat in the trtAssign pull request :) after that is merged I will start the rhub checks.

I still think we should default to one behavior for all function but maybe it would make sense to add a parameter option to turn the copying off/on. I think...

I'm with you on the default as this is (mostly) the simstudy default anyway. Well the in-place changes are the default behavior for data.table for performance reasons. So maybe for...

It does not work on windows with Git 2.29.1 the manager-core is apparently not detected: ![image](https://user-images.githubusercontent.com/16141871/97178875-67ddf780-1798-11eb-8b56-ae7a88e70384.png)

`git_credential_ask` does work though and gets the correct PAT

+1 ``` Service conda-cpp docker-compose config: image: ${REPO}:${ARCH}-conda-cpp build context: . dockerfile: ci/docker/conda-cpp.dockerfile cache_from: ['${REPO}:${ARCH}-conda-cpp'] args repo: ${REPO} arch: ${ARCH} shm_size: 2G ulimits core: ${ULIMIT_CORE} environment ARROW_BUILD_BENCHMARKS: ON ARROW_BUILD_EXAMPLES: ON...

If you want to build the current HEAD from the repo be aware that we now require C++17, so you will need to install devtoolset and enable it prior to...

@raulcd @kou could you review this?

To avoide the `None` version issue you have to set `SETUPTOOLS_SCM_PRETEND_VERSION=10.0.0`, the var is added to the env node and will be passed on to the buiild.