Jacob Wujciak-Jens

Results 248 comments of Jacob Wujciak-Jens
trafficstars

I am not sure about this one, there is quite a bit of code dependent on the names other than just the `generate` stuff, so there is a large potential...

that would not really change anything^^ The issue is not with integrating the new distribution names in the generate chain, that's rather easy. But there are a quite a few...

In a way you are right, I will check out what the dependencies are exactly and think about how to best proceed.

This is another issue that would benefit from the switch to r-expressions #75 as these dependencies I mention here would basically all go away,

I think it would be nicer to add another field/parameter for the truncated distributions rather than doubling up all distributions as `dist_trunc`. It would maybe be a good time to...

And another issue to consider when designing the changes for #75 (I'm going through and linking these issues so we don't lose track :) )

Yeah I understand why you did it this way, but we still can check formula formats etc. :) I will hot fix defData for now to get the new evalDef...

One idea I have to unify defData/Add would be to add a `dt` argument to defData which is used to check for previously defined vars in case it is given....

Or the `add` flag could be either a boolean or a dt, in case it is dt we can check validity but in case of bool we just don't check...