Jacob Wujciak-Jens
Jacob Wujciak-Jens
I was still able to reproduce this issue with 9.0.0, it is caused by `PARQUET_REQUIRE_ENCRYPTION` enabled by the `parquet` feature (missing from your manual build)
@kou with your patch and 9.0.0 it looks like only thirf::thrift is still missing? `thrift::thrift` is added to `PARQUET_STATIC_LINK_LIB` though... ``` "OpenSSL::Crypto;OpenSSL::SSL;unofficial::brotli::brotlienc;unofficial::brotli::brotlidec;unofficial::brotli::brotlicommon;BZip2::BZip2;lz4::lz4;Snappy::snappy;ZLIB::ZLIB;zstd::libzstd_static;re2::re2;Threads::Threads;rt;\$" ``` The linking issue also still exists :(...
@diehard2 I'll check :)
I successfully ran `vcpkg install arrow[dataset,flight,json,mimalloc,s3]:x64-windows(-static)?` and the Dockerfile from #22552 cc: @GPSnoopy @jgiannuzzi
@JonLiu1993 Yes I am looking into it. I think the patch for this isn't to bad but I'll open a PR in apache/arrow and link it here.
Thank you @jooolia for your work so far! I just wanted to note that my test coverage as displayed by {pkgcheck} has seemingly dropped below 75% but this is due...
Hey @annakrystalli do you need any input from my side at this point to continue the submission?
@annakrystalli Thanks for the feedback. I'll start to think about how to better show case it but I would also be interested in the reviewers opinions :)
Thank you for your helpful review @pat-s ! I will implement/address your points after the second review as suggested by @annakrystalli
@jimhester It looks like this is caused by some behavior change in `testthat` when on CRAN as the coverage is detected correctly when `NOT_CRAN` is set to `true` (and it...