zzak
zzak
@fatkodima Thanks for taking a look! > remove_foreign_key :books, :users # removes fkey on author_id I feel this is a bug and it should raise, but also that is kind...
@fatkodima No sorry, a few small things I need to change, and check the SQLite part doesn't break anything
@fatkodima I think this is ready for another review. Couple changes: * Reverted the change to sqlite3, test coverage was a concern * Added TableDefinition with tests (for change_table,etc apis)...
@fatkodima Sorry had a few things come up, I've added back the sqlite part with some tests and one other tiny refactor. I thought about possibly moving the check into...
Can confirm this fixes the build, I was just checking if it was my PR but seems all related to Rack 3 changes.
So if you're not using sprockets what is the default? I think the wording here is a little confusing, but don't have a suggestion now sorry :bow:
I'd hate to suggest it but maybe a table for the different values by plugin, then I'm also wondering if we should just leave it up to those gems to...
Could we explore expanding the `touch` option to accept more than true/false? e.g. `touch: :all` vs. `touch: :each` That way we can clearly document the trade-offs and let the developer...
Yeah, I'm not sure what to do because underneath `rate_limit` is just a before_action. So it seems like it would be quite a lift to support something like clearing the...
We shouldn't have to change the adapter on our end, that file is there because Rails supports more versions than just Sidekiq 8.whatever, and will be deprecated in a future...