Kevin Z

Results 215 comments of Kevin Z

Yeah so you are not posting any useful information here either, what do you expect to happen / to see? what happened / you saw instead?

CraftJob object should also provide a `cancel()` method to directly cancel the job

And for `ae_crafting` event, instead of return 2 pages long arguments, we should give a keyword table which clearly define which argument means what.

yes the code for that part very messy, need some rewrite.

I noticed the highlight area changed, are they randomly generated? I personally think randomly generate stuff on this is not good, so maybe you can set a fixed seed? Or...

I think we can put that to static class init block instead of `commonSetup`?

I wonder if it may has less performance than check a boolean, but I may over thinking it.

Thanks for your investigation! Unfortunately, 1.18.2 only accepts critical fixes. But if you can make a PR for 1.19.2, I'm glad to review it. Or idk if @SirEndii will count...

Yeah the bug and cross dimension teleporting are both fixed/implemented in 0.8

Would you mind do the PR on dev/0.8 instead as we are not receiving any new features on 0.7? Also make sure you run `./gradlew checkstyleMain` to have a uniformed...