AdvancedPeripherals icon indicating copy to clipboard operation
AdvancedPeripherals copied to clipboard

ME and RS Bridge crafting events

Open SirEndii opened this issue 11 months ago • 4 comments

A thing that really annoys a lot of players is that the crafting functions of our storage system bridges don't provide any information if a job is done, was calculated successfully

We can either track these jobs ourselves and keep a custom object in the bridge like it's currently done in the ME Bridge https://github.com/IntelligenceModding/AdvancedPeripherals/blob/7aa2a7637a5f609da6ac25d51214c1a0e0ebf863/src/main/java/de/srendi/advancedperipherals/common/blocks/blockentities/MeBridgeEntity.java#L39

Then we can provide functions like getJobs, getJob(itemFilter/JobId) How we exactly do this is discussable

SirEndii avatar Jan 15 '25 19:01 SirEndii

Related issues:

  • https://github.com/IntelligenceModding/Advanced-Peripherals-Features/issues/100
  • https://github.com/IntelligenceModding/Advanced-Peripherals-Features/issues/83
  • https://github.com/IntelligenceModding/Advanced-Peripherals-Features/issues/38
  • https://github.com/IntelligenceModding/Advanced-Peripherals-Features/issues/51

SirEndii avatar Jan 15 '25 20:01 SirEndii

CraftJob object should also provide a cancel() method to directly cancel the job

zyxkad avatar Jan 23 '25 01:01 zyxkad

And for ae_crafting event, instead of return 2 pages long arguments, we should give a keyword table which clearly define which argument means what.

zyxkad avatar Jan 23 '25 01:01 zyxkad

It would be also nice to have a method that marks a CraftJob as done.

Zonk1987 avatar Aug 26 '25 04:08 Zonk1987