AdvancedPeripherals icon indicating copy to clipboard operation
AdvancedPeripherals copied to clipboard
verified publisher icon IntelligenceModding

Add pattern grid turtles

Open JCLemme opened this issue 3 months ago • 6 comments

  • Please check if the PR fulfills these requirements
  • [X] The commit message are well described
  • [X] Docs have been added / updated (for features or maybe bugs which were noted). If not, please update the needed documentation here. Feel free to remove this check if you don't need it
  • [~] All changes have fully been tested

  • What kind of change does this PR introduce? (Bug fix, feature, ...) Feature

  • What is the current behavior? (You can also link to an open issue here) Turtles cannot equip or otherwise interact with pattern grids

  • What is the new behavior (if this is a feature change)? Turtles can now equip pattern grids to write patterns: see below https://github.com/IntelligenceModding/Advanced-Peripherals-Features/issues/125

  • Does this PR introduce a breaking change? (What changes might users need to make in their scripts due to this PR?) Not to my knowledge

  • Other information: I'd like to add unit tests if this project is set up for them

JCLemme avatar Oct 04 '25 00:10 JCLemme

Would you mind do the PR on dev/0.8 instead as we are not receiving any new features on 0.7? Also make sure you run ./gradlew checkstyleMain to have a uniformed style in the respoistry.

zyxkad avatar Oct 04 '25 00:10 zyxkad

You know what, feel free to keep this PR open but as zyxkad said, please port it also to dev/0.8(1.19.2)

I usually don't want to add new features to 0.7, but I don't see myself working a lot on 0.8 the near future to finish a release - so it won't hurt to release it here too, we can then just add a hint in the docs

SirEndii avatar Oct 04 '25 00:10 SirEndii

Build Preview

badge

You can find files attached to the below linked Workflow Run URL (Logs).

Name Link
Commit 32a5db0eaee2be42e76ae0a8bd424194afd54f7c
Logs https://github.com/IntelligenceModding/AdvancedPeripherals/actions/runs/18657115082
Jar Files AdvancedPeripherals PR 790
Expires At 2026-01-18T15:50:51Z

github-actions[bot] avatar Oct 04 '25 00:10 github-actions[bot]

On it.

JCLemme avatar Oct 04 '25 03:10 JCLemme

I will hopefully find time next week to review all PRs

SirEndii avatar Oct 19 '25 20:10 SirEndii

I need to test this and #791 ingame Not a huge fan of two different ways to create patterns for each peripheral - but I need to test it to decide what we will do

SirEndii avatar Oct 20 '25 15:10 SirEndii