Zeeshan Ali Khan
Zeeshan Ali Khan
> Could this be changed to a type alias instead of a newtype, or would that not work for some reason? > > ```rust > type OwnedValue = Value This...
In GitLab by @ids1024 on Mar 10, 2021, 15:36 I *think* this would only break code that depends on `OwnedValue` and `Value
> I *think* this would only break code that depends on `OwnedValue` and `Value
In GitLab by @ids1024 on Mar 10, 2021, 16:47 What comes to mind is something like this: ```rust trait Foo; impl Foo for OwnedValue {} impl {} ``` These will...
> What comes to mind is something like this: Right, that's true. > But I assume code using zbus/zvariant isn't likely do be doing things like that. Yeah, me too....
> I've a [WIP branch](https://gitlab.freedesktop.org/dbus/zbus/-/commit/4e7a41351e57cb8571115cad76bab5e9983d585b) that I really should finish up very soon. Perhaps that conversion also helps here? If it can, I'd prefer that route over potentially break the...
Hmm.. I tried: ```rust impl, Error = E>, E: Into, ``` And I get `unconstrained type parameter for E` error. So we'll probably need to try the non-ideal way. :(
In GitLab by @ids1024 on Mar 15, 2021, 23:01 It seems that should be: ```rust impl>, T::Error: Into ``` But that fails with "type parameter `T` must be covered by...
> > But I assume code using zbus/zvariant isn't likely do be doing things like that. > > Yeah, me too. If they are, I wouldn't feel too bad about...
Although we don't know for sure if this will require an API break but I'm adding the tag anyway since it's likely.