Zeeshan Ali Khan
Zeeshan Ali Khan
@shubham14bajpai as the test run points out the format is wrong in some places. Did you run `cargo fmt` on it? I guess like me (and perhaps other?) you remove...
> Yes when I enable it a lot of files are throwing errors. Oh for you as well? I wonder how that's been working since CI uses the same rust...
> whereas `tokio::sync::Semaphore` calls it `add_permits()`: That seems to be doing something different: allowing more number of concurrent holders. I'm all for both APIs though.
> I was wondering if there is a "easy" and _correct_ way to make this implementation fair. I wouldn't know of any (at least a simple-enough one). @taiki-e would you...
Thanks @joshtriplett ! LGTM. Could see check why the mini test is failing?
> Thanks @joshtriplett ! LGTM. Could see check why the mini test is failing? Ah nm. @taiki-e already fixed it: https://github.com/smol-rs/async-lock/pull/26 . Can you rebase?
@smol-rs/admins so any objections in merging this?
Write about how coherence makes it nearly impossible to establish standard traits outside of libstd.
> Anecdotally, I think this extends beyond just async: imagine trying to introduce a replacement for `serde` today. I had the misfortune of running into something similar with [zvariant](https://crates.io/crates/zvariant), where...
Oh, perhaps we should have covered this as part of #176?
@anguslees that's a very good point. We should also keep in mind that serde has been [unmaintained](https://github.com/serde-rs/serde/issues/1723) for almost 2 years now.