Zeeshan Ali Khan
Zeeshan Ali Khan
> The requirements of the `g_variant_builder_end()` API will be a bit annoying to implement. How so? >It is not permissible to use builder in any way after this call That's...
> > That's easy with binding for `g_variant_builder_end()` take `self` instead of `&mut self`, no? > > It's refcounted, so that's not enough :) But the Rust wrapper struct we'll...
Hi, Just to let you know that high level async service-side API are now available in the [latest 2.0 beta release](https://docs.rs/zbus/2.0.0-beta.7/zbus/index.html) if you want to try porting the code already....
FYI, zbus 2.0 (stable) has been out for almost 6 months now and provides async API for both client and server-side. It's been well-received so far and our downloads are...
@shubham14bajpai Great work! Could you please split the patch into [smaller logical ones](https://dev.to/paulinevos/atomic-commits-will-help-you-git-legit-35i7)? Pro-tip: when your PR/commit description has sentence with "also adds/changes", it's a good indication that part can...
That was super fast work! LGTM
@shubham14bajpai But let's wait for someone more familiar with the code, have a look before merging.
> Addressed most of the review comments. :+1: Please do resolve the conversations that you've addressed as suggested by the reviewer in question. > Still trying to figure out how...
> > Please do resolve the conversations that you've addressed as suggested by the reviewer in question. > > Done +1 Great. Could you please squash the fixups to you...
bors try