Zeeshan Ali Khan

Results 481 comments of Zeeshan Ali Khan

Adding "API break" tag cause keeping the source trait around could easily conflict with other symbols in the module (e.g the trait impl via `dbus_interface` macro).

@BurntSushi could you please have a look?

@BurntSushi Given that you explicitly asked me for this PR and it's a simple change that will likely help a lot of people avoid bumping into the serious and unexpected...

> even trace would be too loud imho - and since it's not an error, it should not say so) trace is supposed to be super verbose IMO but sure,...

I wonder if there is anything other than an error this `Future` impl can return. If it can only resolve to an error, that's what the output should be and...

In GitLab by @peelz on Jan 31, 2023, 02:11 It should probably return a `Result` in case the connection were to close gracefully (see #309).

hmm.. yeah if we go for #309, then definitely.

@jhartzell42 Thanks. I'll have a look soon.

If by support you mean `Type` impl, we already support [`time::Duration`](https://gitlab.freedesktop.org/dbus/zbus/-/blob/main/zvariant/src/type.rs#L410) at least. You need to enable `time` feature though.

In GitLab by @sophie-h on May 9, 2023, 01:35 But I don't have any need to use `time` instead of std